Skip to content

luaformatter: 1.3.5 -> 1.3.6#123530

Merged
SuperSandro2000 merged 1 commit into
NixOS:masterfrom
figsoda:luaformatter
May 19, 2021
Merged

luaformatter: 1.3.5 -> 1.3.6#123530
SuperSandro2000 merged 1 commit into
NixOS:masterfrom
figsoda:luaformatter

Conversation

@figsoda

@figsoda figsoda commented May 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Member
Motivation for this change

Also fixes build on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 18, 2021
@r-rmcgibbo

r-rmcgibbo commented May 18, 2021

Copy link
Copy Markdown

Result of nixpkgs-review pr 123530 at 8e450b9f run on x86_64-linux 1

2 packages built successfully:
  • luaformatter
  • tests.trivial

@figsoda figsoda force-pushed the luaformatter branch 2 times, most recently from 5eaeabe to 19dbeaf Compare May 19, 2021 14:24
@figsoda figsoda marked this pull request as draft May 19, 2021 14:26
@figsoda figsoda marked this pull request as ready for review May 19, 2021 14:31
@nixos-discourse

nixos-discourse commented May 19, 2021

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/526

@SuperSandro2000 SuperSandro2000 merged commit bbc6b50 into NixOS:master May 19, 2021
@figsoda figsoda deleted the luaformatter branch May 19, 2021 15:54
@figsoda figsoda mentioned this pull request Aug 31, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@figsoda @r-rmcgibbo @nixos-discourse @SuperSandro2000